Skip to content

[release-4.17] CNTRLPLANE-1611: Backport StreamingCollectionEncoding for JSON and protobuf #2486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Oct 21, 2025
Merged

[release-4.17] CNTRLPLANE-1611: Backport StreamingCollectionEncoding for JSON and protobuf #2486

merged 8 commits into from
Oct 21, 2025

Conversation

rh-roman
Copy link

@rh-roman rh-roman commented Oct 6, 2025 •
edited
Loading

Due to significant customer need for performance improvements related to API server pressure from large LIST requests, backporting the API streaming features that have been introduced in 1.33/1.34 related to kubernetes/enhancements#3157

Metrics 4.17 vs 4.17 with StreamingCollectionEncoding enabled doc

@openshift-ci-robot openshift-ci-robot added the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label Oct 6, 2025
@openshift-ci-robot
Copy link

@rh-roman: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@rh-roman
Copy link
Author

rh-roman commented Oct 6, 2025

/test all

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 6, 2025
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Oct 6, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the vendor-update Touching vendor dir or related files label Oct 6, 2025
@rh-roman rh-roman changed the title [release-4.17] Backport StreamingCollectionEncoding for JSON and protobuf [release-4.17] CNTRLPLANE-1611: Backport StreamingCollectionEncoding for JSON and protobuf Oct 8, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 8, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 8, 2025 •
edited by openshift-ci bot
Loading

@rh-roman: This pull request references CNTRLPLANE-1611 which is a valid jira issue.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

nkeert and others added 3 commits October 8, 2025 14:44
@nkeert @rh-roman
UPSTREAM: 130190: Add a test to validate deferredResponseWriteron mul…
e24b655 
…tiple write calls

Signed-off-by: nkeert <[email protected]>
@z1cheng @rh-roman
UPSTREAM: 130281: Implement chunking for gzip encoder in deferredResp…
116aee8 
…onseWriter

Signed-off-by: z1cheng <[email protected]>
@serathius @rh-roman
UPSTREAM: 130220: Add tests for encoding collections in JSON for KEP-…
e41d50f 
…5116

Used test cases from:
* Original PR kubernetes#129334
* KEP https://github.com/kubernetes/enhancements/tree/master/keps/sig-api-machinery/5116-streaming-response-encoding#unit-tests

For now testing current serializer implementation to show encoder
behavior and agree on set of tests. Having a separate PR should make review easier.
In separate PR will add the implementation for streaming that should
provide same response byte-to-byte.
@rh-roman rh-roman force-pushed the backport-api-stream-417 branch from 72eeada to 04b1d9e Compare October 9, 2025 15:57
@openshift-ci-robot
Copy link

@rh-roman: the contents of this pull request could not be automatically validated.

The following commits are valid:

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 9, 2025 •
edited by openshift-ci bot
Loading

@rh-roman: This pull request references CNTRLPLANE-1611 which is a valid jira issue.

In response to this:

Due to significant customer need for performance improvements related to API server pressure from large LIST requests, backporting the API streaming features that have been introduced in 1.33/1.34 related to kubernetes/enhancements#3157

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@rh-roman rh-roman marked this pull request as ready for review October 9, 2025 16:00
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 9, 2025
@openshift-ci openshift-ci bot requested review from deads2k and jerpeter1 October 9, 2025 16:02
@rh-roman rh-roman force-pushed the backport-api-stream-417 branch from 04b1d9e to c1a5765 Compare October 10, 2025 13:49
@openshift-ci-robot
Copy link

@rh-roman: the contents of this pull request could not be automatically validated.

The following commits are valid:

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@rh-roman rh-roman force-pushed the backport-api-stream-417 branch from c1a5765 to 223ff4d Compare October 10, 2025 14:52
@openshift-ci-robot
Copy link

@rh-roman: the contents of this pull request could not be automatically validated.

The following commits are valid:

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@benluddy
Copy link

/test images

@rh-roman rh-roman force-pushed the backport-api-stream-417 branch from 223ff4d to a94a78e Compare October 10, 2025 20:31
@openshift-ci-robot
Copy link

@rh-roman: the contents of this pull request could not be automatically validated.

The following commits are valid:

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Oct 11, 2025 •
edited
Loading

@rh-roman: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-csi 72eeada link false /test e2e-aws-csi
ci/prow/k8s-e2e-aws-ovn-serial 72eeada link false /test k8s-e2e-aws-ovn-serial
ci/prow/e2e-agnostic-ovn-cmd 72eeada link false /test e2e-agnostic-ovn-cmd

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@rh-roman
Copy link
Author

/retest

@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 18, 2025 •
edited by openshift-ci bot
Loading

@rh-roman: This pull request references CNTRLPLANE-1611 which is a valid jira issue.

In response to this:

Due to significant customer need for performance improvements related to API server pressure from large LIST requests, backporting the API streaming features that have been introduced in 1.33/1.34 related to kubernetes/enhancements#3157

Metrics 4.17 vs 4.17 with StreamingCollectionEncoding enabled doc

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@benluddy benluddy mentioned this pull request Oct 21, 2025
Open
@benluddy
Copy link

/lgtm
/remove-label backports/unvalidated-commits
/label backport-risk-assessed
/label jira/valid-bug

@openshift-ci openshift-ci bot added backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Oct 21, 2025
@openshift-ci openshift-ci bot removed the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label Oct 21, 2025
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 21, 2025
@benluddy
Copy link

/assign @bertinatto

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Oct 21, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: benluddy, bertinatto, rh-roman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 21, 2025
@benluddy
Copy link

/verified by @rh-roman

@openshift-ci-robot
Copy link

@benluddy: This PR has been marked as verified by @rh-roman.

In response to this:

/verified by @rh-roman

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Oct 21, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit ff6c884 into openshift:release-4.17 Oct 21, 2025
18 checks passed
@rh-roman rh-roman deleted the backport-api-stream-417 branch October 21, 2025 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bertinatto bertinatto bertinatto approved these changes

@deads2k deads2k Awaiting requested review from deads2k

@jerpeter1 jerpeter1 Awaiting requested review from jerpeter1

Assignees

@benluddy benluddy

@bertinatto bertinatto

@kasturinarra kasturinarra

@zhouying7780 zhouying7780

@xingxingxia xingxingxia

@lyman9966 lyman9966

@duanwei33 duanwei33

@wangke19 wangke19

@gangwgr gangwgr

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. vendor-update Touching vendor dir or related files verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.